Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Deal properly with name clashes #3

Closed
ndmitchell opened this issue Dec 17, 2017 · 4 comments
Closed

Deal properly with name clashes #3

ndmitchell opened this issue Dec 17, 2017 · 4 comments
Labels
good first issue

Comments

@ndmitchell
Copy link
Owner

If you write:

foo x = case x of
   x:xs -> ...

Then it records x twice as different values, overwriting each other. They should be handled uniquely.
@marklnichols
Copy link
Contributor

I'm going to start looking at this one now...

@marklnichols
Copy link
Contributor

I don't think I can reopen issues, but can we reopen this one? I was working on this a bit, and the plan was to show each of the separate values whenever a variable is shadowed. I can see from the first test I have that this isn't happening.

@ndmitchell ndmitchell reopened this Jan 26, 2018
@ndmitchell
Copy link
Owner Author

As requested. I'm happy for you to have reopen privileges, but I don't really know how... I thought everyone could do it by default.

@marklnichols
Copy link
Contributor

This is done now.

ndmitchell pushed a commit that referenced this issue Feb 16, 2018
@marklnichols
Merge pull request #3 from ndmitchell/master
53096de 
Merging changes from the main fork
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
good first issue
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@ndmitchell @marklnichols