Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Future-proof against addition of Data.List.unsnoc #103

Merged
merged 1 commit into from Jun 24, 2023
Merged

Future-proof against addition of Data.List.unsnoc #103

merged 1 commit into from Jun 24, 2023

Conversation

Bodigrim
Copy link
Contributor

There is a CLC proposal to add Data.List.unsnoc to base: haskell/core-libraries-committee#165. This draft PR makes extra compatible with this potential change.

@Bodigrim
Copy link
Contributor Author

@ndmitchell the CLC proposal has been approved, so this is ready for review. macOS build failure seems unrelated to the change.

@Bodigrim
Copy link
Contributor Author

@ndmitchell just a gentle reminder.

@ndmitchell ndmitchell merged commit 38f0f32 into ndmitchell:master Jun 24, 2023
7 of 8 checks passed
ndmitchell added a commit that referenced this pull request Jul 1, 2023
@tomjaguarpaw
Copy link

This change doesn't make much sense to me. It means that I can't write code that uses unsnoc that is compatible with both GHC <= 9.8 and GHC >= 9.10 using extra (without using CPP myself).

If, by contrast, this PR rexported Data.List.unsnoc for GHC >= 9.10 then I could. Should we do that instead?

@tomjaguarpaw
Copy link

Ah, but I see that Data.List is already re-exported in its entirety. Thanks to @ChickenProp for pointing this out haskell/core-libraries-committee#227 (comment)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants