Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

iterate id and zipWith/repeat rules (Closes #41) #42

Merged
merged 1 commit into from Apr 15, 2014
Merged

iterate id and zipWith/repeat rules (Closes #41) #42

merged 1 commit into from Apr 15, 2014

Conversation

nomeata
Copy link
Contributor

@nomeata nomeata commented Apr 15, 2014

I was correcting a Haskell exam and found that some students would write
such code. Hopefully these students will use hlint when they do real
programming.

I was correcting a Haskell exam and found that some students would write
such code. Hopefully these students will use hlint when they do real
programming.
@nomeata nomeata mentioned this pull request Apr 15, 2014
ndmitchell added a commit that referenced this pull request Apr 15, 2014
iterate id and zipWith/repeat rules (Closes #41)
@ndmitchell ndmitchell merged commit e4e3462 into ndmitchell:master Apr 15, 2014
@ndmitchell
Copy link
Owner

Thanks, these hints look very nice.

ndmitchell added a commit that referenced this pull request Apr 15, 2014
@ndmitchell
Copy link
Owner

The hints were nice but there were a few syntactic wobbles - mostly using ==> instead of = and you can't use xs in a hint - it must be x (single letter variables are considered unbound). I've fixed those after. I'm planning to write QuickCheck tests for these things soon.

@nomeata
Copy link
Contributor Author

nomeata commented Apr 15, 2014

sorry for not testing them, it looked simple enough™ :-)

@ndmitchell
Copy link
Owner

I took a quick look and spotted nothing wrong, but my travis instance did - I rarely test my code anymore, just let automated services do it for me!

@nomeata
Copy link
Contributor Author

nomeata commented Apr 15, 2014

Hmm, shound’t travis have tested my pull request before you merged it?

@ndmitchell
Copy link
Owner

Yes, and last week it would have. But at the moment Travis is having a bit of a wobble (it was yesterday as well) so the tests show up after-the-fact, with little indication it might intend to do a test. I notice that now it has tested your patch and rejected it, but when I merged, it didn't even have the "in progress" symbol.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants