Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make it possible to output verbatim cmd arguments #466

Closed
nkaretnikov opened this issue Jun 16, 2016 · 3 comments
Closed

Make it possible to output verbatim cmd arguments #466

nkaretnikov opened this issue Jun 16, 2016 · 3 comments

Comments

@nkaretnikov
Copy link

nkaretnikov commented Jun 16, 2016

Spent quite a while yesterday trying to understand why gcc didn't like my linker script, resulting in a generic error, while the printed command in the output worked fine. I suspected formatting issues early enough, but still some time was spent searching for the said generic error on the web. Turned out I needed to pass my ldflags as a string rather than a list of strings, so a single unwords did it.

I know there's a note about that in the haddocks. Still, it would be nice to dump something unambiguous. Show output, perhaps, if it's just value constructors, assuming it's not too verbose (haven't looked at the relevant instances, maybe it's worthless).

@nkaretnikov
Copy link
Author

(In addition to the existing output, of course.)

@ndmitchell
Copy link
Owner

What about the current printing sufficient? I would expect it to differ between:

link "-La b c"
link -La b c

Can you give an example of the output you got from the command failure? And what that corresponded to underneath? The Show output captures a lot of internal details to Shake, but in the end it's either a String (for Shell) or [String]. However, I had hoped the existing show was unambiguous enough - if not, I'd like to do better.

@ndmitchell
Copy link
Owner

Closing since I don't have an example to work with (please reopen if you can give the example - I'm keen to fix it if I can reproduce).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants