Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow to disable --compact #672

Closed
pepeiborra opened this issue Apr 28, 2019 · 2 comments · Fixed by #675
Closed

Allow to disable --compact #672

pepeiborra opened this issue Apr 28, 2019 · 2 comments · Fixed by #675

Comments

@pepeiborra
Copy link
Contributor

--compact is pretty good but it doesn't work in non terminals, such as CI. It's also not possible to set it programmatically.

We could use a way to disable it from command line (e.g. --no-compact), or additional smarts that self-disable it when not in a terminal device (or when the terminal device is DUMB).

@pepeiborra
Copy link
Contributor Author

I'm happy to implement this if you let me know what is your preferred option

@ndmitchell
Copy link
Owner

Since --compact has to be added explicitly isn't it easier to just not set it on CI?

I still don't have a good idea of what the API should be for compact. It's a bit cross cutting - it prods a few fields in ShakeOptions to do its job. Making it not turn on when the terminal device is dumb is one way - you could have --compact=auto to mean only turn on if terminal is not dumb?

Not that Compact already has an idea if it's going to work or not, see https://github.com/ndmitchell/shake/blob/master/src/Development/Shake/Internal/CompactUI.hs#L64

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants