-
Notifications
You must be signed in to change notification settings - Fork 118
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Decouple AutoDeps from linter #334
Conversation
If at some point you want to get rid of tracker.exe it would be easier to make AutoDeps faster (no need to parse/filter writes). |
Can you think of any reason not to get rid of Tracker? Is there anything it does that autodeps doesn't? Open-source cross-platform legally-distributable code seems like a big win. |
Here is a list:
I'm not particularly worried about those, but you might think otherwise. |
Maybe we could just use |
That would imply running the command twice when both options are in place, maybe not a good idea. |
Hmmm, now I'm thinking the best option is to just leave the listing part as it is and provide a faster AutoDeps, I'll attempt that this afternoon. |
Tracker works the same way, as do lots of things like process explorer, so I imagine this would be a bit of a nasty break.
Sounds like a good reason to perhaps use Tracker in the fsatrace test suite, not integrated into Shake.
I don't expect either approach to be perfect, given what it's doing. Please remove LintTracker if you want to. PS. I'm somewhat under the weather with cold/flu style stuff, so I'm probably not going to be in a fit state to review code to the necessary level of attention to detail until after a nap or tomorrow. I'm giving it a quick skim though, and will yell if anything looks wrong. |
OK, let's see how it would look like without tracker... |
With fe1c4f4 I still get excessive allocation/time in AutoDeps:
Any idea? |
Decouple AutoDeps from linter
No description provided.