Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement getShakeExtra #503

Merged
merged 1 commit into from
Dec 20, 2016
Merged

Implement getShakeExtra #503

merged 1 commit into from
Dec 20, 2016

Conversation

bgamari
Copy link
Contributor

@bgamari bgamari commented Dec 15, 2016

This is a convenient utility to extract a particular key from shakeExtra.
Unfortunately we can't make this interface typesafe since shakeExtra is a bit
too general: there is no known relationship between the key TypeRep and the
value at that key.

This is a convenient utility to extract a particular key from shakeExtra.
Unfortunately we can't make this interface typesafe since shakeExtra is a bit
too general: there is no known relationship between the key TypeRep and the
value at that key.
@ndmitchell
Copy link
Owner

I think the right thing to do is to add a corresponding addShakeExtra which does the insert correctly, and also at startup check all items in shakeExtra obey the types/values invariant. I'll add those changes on top of this.

@ndmitchell ndmitchell merged commit f2406e7 into ndmitchell:master Dec 20, 2016
ndmitchell added a commit that referenced this pull request Dec 23, 2016
ndmitchell added a commit that referenced this pull request Dec 28, 2016
ndmitchell added a commit that referenced this pull request Dec 28, 2016
ndmitchell added a commit that referenced this pull request Dec 28, 2016
ndmitchell added a commit that referenced this pull request Dec 28, 2016
ndmitchell added a commit that referenced this pull request Dec 28, 2016
@ndmitchell
Copy link
Owner

I added addShakeExtra and made it an extra for shakeExtra to not obey the obvious invariant - meaning the failure in getShakeExtra is now impossible to hit.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants