Fix parsing peak usage when value is not set #143
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Nov 2, 2023
jbouwh
suggested changes
Nov 5, 2023
| output = "{}\t[{}] at {} occurred {}"\ | ||
| .format(str(self.value), str(self.unit), str(self.datetime.astimezone().astimezone(pytz.utc).isoformat()), | ||
| str(self.occurred.astimezone().astimezone(pytz.utc).isoformat())) | ||
| .format(str(value), str(self.unit), str(timestamp), str(timestamp_occurred)) |
There was a problem hiding this comment.
I suggest using an f-formatted string here
There was a problem hiding this comment.
f-format is nowhere used in the code atm. Let's keep this for now and maybe do a follow-up PR to replace then all at once?
ejpalacios
suggested changes
Nov 5, 2023
Sometimes peak usage is not yet visible in the 13 months history code. It gives a 0.0kW value with timestamp (632525252525W). Also the peak usage value can be invalid, handle this case also.
dupondje
force-pushed
the
fix_invalid_occured
branch
from
f796db1
to
389bcef
Compare
jbouwh
approved these changes
Nov 6, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Sometimes peak usage is not yet visible in the 13 months history code. It gives a 0.0kW value with timestamp (632525252525W).
This commit fixes handling this case.