Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DSMR 2.2 #2

Merged
merged 8 commits into from
Nov 8, 2016
Merged

DSMR 2.2 #2

merged 8 commits into from
Nov 8, 2016

Conversation

aequitas
Copy link
Contributor

@aequitas aequitas commented Nov 7, 2016

Hi,

I added DSMR V2.2 support so I can use this module with my smartmeter (Iskra MT 382). I took the liberty of including a test suite and a simple console script for testing.

Would you be so kind to release this as a new version? My intention is to use this module to integrate with https://github.com/home-assistant/home-assistant as i figured it would be less work to contribute to this project than to refactor my own buggy implementation.

@aequitas
Copy link
Contributor Author

aequitas commented Nov 8, 2016

I adjusted the version constraint for pyserial to make integration with other projects more practical and added a travis config:

Build Status

@aequitas aequitas mentioned this pull request Nov 8, 2016
12 tasks
@ndokter ndokter merged commit ba29e34 into ndokter:master Nov 8, 2016
@ndokter
Copy link
Owner

ndokter commented Nov 8, 2016

Thanks for the work. I merged your changes and created a new version.

It works on my end. Please let me know if you run into troubles.

@aequitas
Copy link
Contributor Author

aequitas commented Nov 8, 2016

Awesome. Just installed it from pip, works as expected. I'm going to continue working on the HASS integration, might be that I need to add some non blocking IO stuff. Will create a pull request if needed.

@aequitas aequitas mentioned this pull request Nov 8, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants