Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Optional NUL after checksum #26

Merged
merged 1 commit into from
Sep 18, 2017
Merged

Optional NUL after checksum #26

merged 1 commit into from
Sep 18, 2017

Conversation

vavdb
Copy link
Contributor

@vavdb vavdb commented Sep 15, 2017

Some smart meters can return 00 0D 0A after the checksum instead of just 0D 0A.

My smart meter returns 00 0D 0A after the checksum, not just 0D 0A.
@ndokter ndokter merged commit 41381f1 into ndokter:master Sep 18, 2017
@codecov-io
Copy link

Codecov Report

Merging #26 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master      #26   +/-   ##
=======================================
  Coverage   67.78%   67.78%           
=======================================
  Files          12       12           
  Lines         298      298           
  Branches       26       26           
=======================================
  Hits          202      202           
  Misses         94       94           
  Partials        2        2
Impacted Files Coverage Δ
dsmr_parser/clients/telegram_buffer.py 100% <ø> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c78ebe3...e3203a5. Read the comment docs.

@ndokter
Copy link
Owner

ndokter commented Sep 18, 2017

Thank you. Ive made a new release with your fix included. Due to a lost interest at the moment, i havent taken the time to test it though..

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants