-
Notifications
You must be signed in to change notification settings - Fork 47
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Introduce useTimezoneSelect
hook
#81
Conversation
Love this use-case! If you could take a look at the merge conflicts, we can get this merged soon. Sorry its taken me forever to get back around to these! |
e514532
to
1354f2d
Compare
I rebased the changes on main. I also got rid of the .d.ts files, because they just duplicate all the types with the |
Ahh I guess thats why I was having issues with the Also, no I'm not sure what the deal with the Anyway, I just pushed a small commit to EDIT: Did it for you 😊 |
Removed the As soon as we get this PR out it should be good to go then 👍 |
Okay so tests pass, lets merge! 🥳 |
Released in |
Description
This PR implements a solution for the issue discussed in #64.
I basically extracted a hook named
useTimezoneSelect
out ofTimezoneSelect
that exposes the options creation and theparseTimezone
function to allow using other UI implementations for the Select dropdown (Semantic UI in our case).Also added some documentation to the README and made the example use it as well.
Linked Issues
#64