Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Read UTF-8 data as UTF-8 #2

Closed
wants to merge 2 commits into from
Closed

Read UTF-8 data as UTF-8 #2

wants to merge 2 commits into from

Conversation

svenstaro
Copy link

You have UTF-8 data that you read during configuration but it might be read as ASCII on systems that use LC_ALL="C". This is the case with configuration scripts such as ansible. My patch is a compatible way of opening UTF-8 as UTF-8 at all times. And yes, this is an actual error for us otherwise.

ndparker added a commit to ndparker/setup-common that referenced this pull request Nov 2, 2014
ndparker added a commit that referenced this pull request Nov 2, 2014
@ndparker
Copy link
Owner

ndparker commented Nov 2, 2014

Thanks. Apparently Github failed to notify me about this PR :/

For various reasons I reworked your patches. The result is in commit ac31f03. I don't want to use io.open in python2, because the _setup stuff is supposed to work with older versions as well (also, it's subtree'd now).

Can you give the current HEAD a shot? If it works properly, I'll use the same changes for the other projects (like rcssmin), too.

@svenstaro
Copy link
Author

Works for me. The latin-1 does confuse me a bit, though.

@ndparker
Copy link
Owner

ndparker commented Nov 3, 2014

Thanks.

Those latin-1 parts modifiy epydoc output. This is just the failsafe way to do it.

@svenstaro svenstaro closed this Nov 3, 2014
@svenstaro
Copy link
Author

Looks resolved to me then!

@ndparker
Copy link
Owner

ndparker commented Nov 3, 2014

Great. Thanks again.

@svenstaro
Copy link
Author

Can you make a release for this so people on PyPI get it too? Last release is also quite long ago.

@ndparker
Copy link
Owner

ndparker commented Nov 6, 2014

Yes, as soon as I have some free cycles. The last release happened so long ago, because nothing changed so far :-)

ndparker added a commit that referenced this pull request Nov 16, 2014
ndparker added a commit that referenced this pull request Oct 11, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants