Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enabling optimizing FFTs for dprime #130

Merged
merged 10 commits into from
Jan 13, 2023
Merged

Enabling optimizing FFTs for dprime #130

merged 10 commits into from
Jan 13, 2023

Conversation

hneth
Copy link
Collaborator

@hneth hneth commented Jan 13, 2023

This PR mostly enables optimizing for dprime (as goal.threshold, goal.chase, and goal). Changes include:

  • computing dprime values in add_stats() helper (with correction)
  • include dprime values in cue level statistics (in x$cues$thresholds and x$cues$stats)
  • minor cleanups in fftrees_cuerank(), fftrees_threshold_factor_grid() and fftrees_threshold_numeric_grid()

This mostly resolves Issue #93, but the new functionality is not thoroughly tested yet. Initial tests suggest that optimizing for dprime can substantially lower other accuracy measures.

@hneth
Copy link
Collaborator Author

hneth commented Jan 13, 2023

I noted the errors on the 3 ubuntu platforms, but the generic errors

  • Error: Failed to install pandoc
  • Error: Failed to get R 4.2.2

seem not caused by the changes of this PR. Will proceed to merge and hope this gets resolved somehow...

@hneth hneth merged commit 2306df3 into ndphillips:master Jan 13, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant