Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Missing Hadamard Products in Forward pass #11

Closed
bkoyuncu opened this issue Sep 6, 2019 · 2 comments
Closed

Missing Hadamard Products in Forward pass #11

bkoyuncu opened this issue Sep 6, 2019 · 2 comments

Comments

@bkoyuncu
Copy link

bkoyuncu commented Sep 6, 2019

First off thank you for the implementation. Are Hadamard products in the paper missing? Please see the image below and paper that I am referring to for clarification.

Image for equations
Paper

@ndrplz
Copy link
Owner

ndrplz commented Sep 6, 2019

The cell dynamic implemented in this repo is different from the one in the paper you mention.

Probably #8 will answer your question.

To be fair, a couple of years have passed and I can't remember right now why we chose to implement a slightly different dynamic than in the "original" paper.

@DavideA, do you have a better memory?

@bkoyuncu
Copy link
Author

bkoyuncu commented Sep 6, 2019

Thank you, shoud have checked the prev questions first.

@bkoyuncu bkoyuncu closed this as completed Sep 6, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants