Polygon and Triangle Support #44
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
josephbirkner
force-pushed
the
polygons
branch
from
f5428ce
to
595d685
Compare
josephbirkner
requested review from
MisterGC and
l-laura
and removed request for
MisterGC
MisterGC
requested changes
Oct 23, 2023
There was a problem hiding this comment.
I have followed the test procedure:
- used Chrome on macOS to for tests
- visualization seems seems to be fine (would be good to have a reference image)
- hovering, picking elements works, but when selecting one element I don't see any inspection panel
- there error messages that happen quite often/need investigation, please provide feedback or let's directly sync for clarification
Safari:
Chrome:
|
MisterGC
approved these changes
Oct 31, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #41
Fixes #40
Changes:
How to test:
ebDebug.showTestTile()