-
Notifications
You must be signed in to change notification settings - Fork 5
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ISSUE-137: Redefine plugin artifact to work with gradle plugin DSL #208
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Success! - Legacy Sample screenshot test resultsView build for commit b260dbb |
✅ Success! - Flix Sample screenshot test resultsView build for commit b260dbb |
✅ Success! - Flix Library screenshot test resultsView build for commit b260dbb |
DanielJette
changed the title
Define plugin meta-inf with java-gradle-plugin
ISSUE-137: Define plugin meta-inf with java-gradle-plugin
Mar 24, 2024
DanielJette
commented
Apr 1, 2024
DanielJette
force-pushed
the
137-gradle-plugin
branch
from
May 19, 2024 20:37
19fece7
to
b849f02
Compare
DanielJette
temporarily deployed
to
Central Repository Deployment
May 19, 2024 20:38
— with
GitHub Actions
Inactive
DanielJette
force-pushed
the
137-gradle-plugin
branch
from
May 19, 2024 21:29
b849f02
to
6d6199c
Compare
DanielJette
temporarily deployed
to
Central Repository Deployment
May 19, 2024 21:30
— with
GitHub Actions
Inactive
DanielJette
temporarily deployed
to
Central Repository Deployment
May 19, 2024 22:36
— with
GitHub Actions
Inactive
DanielJette
temporarily deployed
to
Central Repository Deployment
May 19, 2024 23:20
— with
GitHub Actions
Inactive
DanielJette
force-pushed
the
137-gradle-plugin
branch
from
May 25, 2024 20:13
6d6199c
to
850c35b
Compare
DanielJette
deployed
to
Central Repository Deployment
May 25, 2024 20:22
— with
GitHub Actions
Active
DanielJette
force-pushed
the
137-gradle-plugin
branch
from
May 26, 2024 17:27
850c35b
to
cdd2099
Compare
@jaredh This seems to work fine without the java-gradle-plugin |
DanielJette
changed the title
ISSUE-137: Define plugin meta-inf with java-gradle-plugin
ISSUE-137: Define plugin artifact to work with gradle plugin DSL
May 26, 2024
DanielJette
changed the title
ISSUE-137: Define plugin artifact to work with gradle plugin DSL
ISSUE-137: Redefine plugin artifact to work with gradle plugin DSL
May 27, 2024
DanielJette
force-pushed
the
137-gradle-plugin
branch
from
May 27, 2024 12:59
047ed7e
to
80d92ba
Compare
jaredh
approved these changes
May 31, 2024
DanielJette
force-pushed
the
137-gradle-plugin
branch
from
May 31, 2024 14:25
80d92ba
to
72a44eb
Compare
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this change accomplish?
Resolves #137
How have you achieved it?
After much experimentation, the solution to properly publish the plugin seems to have been to rename the
artifact
todev.testify.gradle.plugin
(previously justplugin
). This allows the plugin to conform to the Plugin DSL .Scope of Impact and Testing instructions
137-gradle-plugin
)./gradlew Plugin:publishToMavenLocal
)settings.gradle.kts
to referencemavenLocal()
build.gradle.kts
:build.gradle.kts
:plugins { id("dev.testify") }
ExampleInstrumentedTest
and add a new test:./gradlew app:screenshotRecord
./gradlew app:screenshotTest
Alternatively, I have also published this as a preview build. You can test this out by setting the version to
3.0.0-preview04
Notice
Warning
This change must keep
main
in a shippable state; it may be shipped without further notice.