Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add continuous integration #32

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Conversation

pickfire
Copy link
Contributor

Fix #23

@expectocode
Copy link
Member

I notice this is significantly more configuration than the default Github Actions rust config. I assume this is for including clippy? Not sure if we want clippy to be a CI failure anyway

@expectocode
Copy link
Member

For contrast, another project uses this config:

name: Rust

on:
  push:
    branches: [ master ]
  pull_request:
    branches: [ master ]

jobs:
  build:

    runs-on: ubuntu-latest

    steps:
    - uses: actions/checkout@v2
    - name: Build
      run: cargo build --verbose
    - name: Run tests
      run: cargo test --verbose
    - name: Check formatting
      run: cargo fmt -- --check

@pickfire
Copy link
Contributor Author

I believe we should include clippy, no harm doing so. This was taken from a template from rust github actions.

@expectocode
Copy link
Member

@pickfire You mean https://github.com/actions-rs/ right? I'm talking about the default Github Actions stuff

@pickfire
Copy link
Contributor Author

Yes

@expectocode
Copy link
Member

I totally forgot - we added bors to this org, @bb010g what's the plan with that?

@pickfire
Copy link
Contributor Author

pickfire commented May 27, 2020

Wow, we have bors? Nice.

r? @expectocode

@pickfire
Copy link
Contributor Author

r? @expectocode

@expectocode
Copy link
Member

@pickfire i don't think it's set up

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Automated testing
2 participants