Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update NEP-455: storage compute costs for v61 #477

Merged
merged 6 commits into from Jun 2, 2023

Conversation

jakmeier
Copy link
Contributor

Tracks the newly introduced compute costs for protocol version 61.

(draft: the changes are still being merged in, I plan to mark this PR ready for review once the testnet release has been cut and confirmed to include the relevant compute cost values.)

@frol
Copy link
Collaborator

frol commented Apr 21, 2023

@jakmeier Could you provide some references to the prior discussions, and ideally update everyone on the reasoning for the change? 🙏

@frol frol added WG-protocol Protocol Standards Work Group should be accountable S-draft/needs-author-revision A NEP in the DRAFT stage that needs an author revision. A-NEP-Extension A new functionality proposal to existing NEP. Once original author merges changes, we close this. labels Apr 21, 2023
@jakmeier
Copy link
Contributor Author

@jakmeier Could you provide some references to the prior discussions, and ideally update everyone on the reasoning for the change? pray

So far, I wrote down a summary in the linked tracking issue. near/nearcore#8938
Which links further to near/nearcore#8006 which summarizes the analysis and reasoning done.

Would you like to see more details pulled into the NEP itself? Also, do you think the table I added contains the relevant information? So far it's just a quick draft I came up with and I am happy to change it to a format that is more useful to readers.

@frol
Copy link
Collaborator

frol commented Apr 24, 2023

@jakmeier I wish all the details are summarized into the document instead of expecting readers to follow an external link and collect information bit by bit.

@Longarithm
Copy link
Member

@jakmeier testnet release has been cut, is it ready to review? https://github.com/near/nearcore/releases/tag/1.34.0-rc.1

@jakmeier
Copy link
Contributor Author

jakmeier commented Jun 2, 2023

@frol sorry for the delay on this. This is now ready for review. Please let me know if it is detailed enough.

The change is now released to mainnet validators and the protocol change will take effect after voting on protocol version 61 succeeds, earliest possible date is 2023-06-12 15:00 UTC.

@jakmeier jakmeier marked this pull request as ready for review June 2, 2023 12:30
@jakmeier jakmeier requested a review from a team as a code owner June 2, 2023 12:30
@frol frol added S-voting/needs-wg-voting-indication A NEP in the VOTING stage that needs the working group voting indication. and removed S-draft/needs-author-revision A NEP in the DRAFT stage that needs an author revision. labels Jun 2, 2023
@frol
Copy link
Collaborator

frol commented Jun 2, 2023

As a moderator, I take all the reviews put into nearcore implementation as the SME review stage and ask @near/wg-protocol to vote on this NEP (it seems like it should be a quick 👍), and we are good to go.

Copy link
Collaborator

@frol frol left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@bowenwang1996 mentioned offline that it is a minor update to reflect the state of things, so there is no need to require votes from other WG members. So I am merging it.

@frol frol merged commit 4886221 into near:master Jun 2, 2023
3 checks passed
@jakmeier jakmeier deleted the nep455-storage-compute-costs-v61 branch June 2, 2023 16:14
@frol frol added S-approved A NEP that was approved by a working group. and removed S-voting/needs-wg-voting-indication A NEP in the VOTING stage that needs the working group voting indication. labels Jun 2, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-NEP-Extension A new functionality proposal to existing NEP. Once original author merges changes, we close this. S-approved A NEP that was approved by a working group. WG-protocol Protocol Standards Work Group should be accountable
Projects
Status: APPROVED NEPs
Development

Successfully merging this pull request may close these issues.

None yet

4 participants