Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: linter issues in specs/DataStructures/Account #493

Merged
merged 3 commits into from Aug 4, 2023
Merged

fix: linter issues in specs/DataStructures/Account #493

merged 3 commits into from Aug 4, 2023

Conversation

jakmeier
Copy link
Contributor

@jakmeier jakmeier commented Aug 3, 2023

  • remove unused link declarations
  • surround titles and code with blank lines
  • give fenced code a language (using c to format comments)

@jakmeier
fix: linter issues in specs/DataStructures/Account
ddc3154 
- remove unused link declarations
- surround titles and code with blank lines
- give fenced code a language (using c to format comments)
@jakmeier jakmeier added the documentation Improvements or additions to documentation label Aug 3, 2023
@jakmeier jakmeier requested a review from a team as a code owner August 3, 2023 08:28
@jakmeier jakmeier mentioned this pull request Aug 3, 2023
Merged
@jakmeier
Copy link
Contributor Author

jakmeier commented Aug 3, 2023 •
edited

There is still a CI failure due to a dead link, specifically https://learn.figment.io/tutorials/stake-fungible-token

It's used in neps/nep-0141.md and specs/Standards/Tokens/FungibleToken/Core.md. I couldn't find an updated URL, I think the page simply no longer exists.

My suggestion is to replace it with wayback machine links: #494

@jakmeier jakmeier enabled auto-merge (squash) August 4, 2023 10:37
@jakmeier jakmeier merged commit c781b79 into near:master Aug 4, 2023
@frol frol added S-approved A NEP that was approved by a working group. A-Nomicon-Changes An update to the Nomicon documentation. labels Aug 4, 2023
@jakmeier jakmeier deleted the lint_account branch August 4, 2023 19:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@frol frol frol approved these changes

Assignees
No one assigned
Labels
A-Nomicon-Changes An update to the Nomicon documentation. documentation Improvements or additions to documentation S-approved A NEP that was approved by a working group.
Projects
Nomicon
Status: APPROVED FIXES
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@jakmeier @frol