Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: remove const-generics feature impls #107

Merged
merged 1 commit into from
Oct 3, 2022
Merged

Conversation

austinabell
Copy link
Contributor

MSRV is already past const generics (1.55.0), so these specialized impls can be removed. I haven't removed the feature itself to avoid being a breaking change.

I made this change in #104 but separated to here because it is an isolated change.

@matklad
Copy link
Contributor

matklad commented Oct 3, 2022

Let's maybe add MSRV to CI first? const-generics are stabilized piece-wise, so maaybe we are using something from 1.58 unadvertedly or something.

We should also update comment in Cargo.toml which explains what the cosnt-generics feature does (we have such a comment, right? ;) )

Copy link
Contributor

@matklad matklad left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

OTOH, this is an improvent, dosen' need to be blocked on anything.

@austinabell
Copy link
Contributor Author

Let's maybe add MSRV to CI first? const-generics are stabilized piece-wise, so maaybe we are using something from 1.58 unadvertedly or something.

We aren't currently, msrv of this branch is 1.55.0 (same as on master without feature)

Linking to #106 (can add to CI in separate change)

We should also update comment in Cargo.toml which explains what the cosnt-generics feature does (we have such a comment, right? ;) )

I'm assuming this might just be removed on a major version bump (or maybe minor pre 1.0 is sufficient?). There isn't a reason otherwise to keep it

@austinabell austinabell merged commit 4f436f9 into master Oct 3, 2022
@frol frol mentioned this pull request May 31, 2023
@frol frol deleted the austin/rm-cg branch June 2, 2023 20:03
@frol frol mentioned this pull request Jun 6, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants