Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Run clippy --fix #125

Merged
merged 5 commits into from
Feb 8, 2023
Merged

Run clippy --fix #125

merged 5 commits into from
Feb 8, 2023

Conversation

preston-evans98
Copy link
Contributor

No description provided.

@preston-evans98
Copy link
Contributor Author

Initial CI run failed because of spurious network error, but it looks like it also needed a cargo fmt. That's done. I've rebased #124 on top of the format.

@frol
Copy link
Collaborator

frol commented Feb 7, 2023

Well, this is a bit concerning change as this new syntax requires Rust 1.58+ (released in Jan 2022, more than 1 year ago). borsh-rs was historically conservative on the minimum supported Rust version (MSRV) requirement, and this syntax change does not feel to be worth bumping it. Thus, instead of transforming the code to use the new syntax, let's silence this linting rule on the crate level for now by adding #![allow(...)] (let's also leave the comment that we can remove it and apply the syntax changes once we bump the MSRV beyond Rust 1.58).

@preston-evans98
Copy link
Contributor Author

Well, this is a bit concerning change as this new syntax requires Rust 1.58+ (released in Jan 2022, more than 1 year ago). borsh-rs was historically conservative on the minimum supported Rust version (MSRV) requirement, and this syntax change does not feel to be worth bumping it. Thus, instead of transforming the code to use the new syntax, let's silence this linting rule on the crate level for now by adding #![allow(...)] (let's also leave the comment that we can remove it and apply the syntax changes once we bump the MSRV beyond Rust 1.58).

Done! Also rebased #124 on top of this

@frol
Copy link
Collaborator

frol commented Feb 8, 2023

@preston-evans98 CI still fails due to borsh/src/generate_schema_schema.rs being a separate binary where we should also add this #![allow] marker. Once CI is green, I am ready to merge this and #124 PRs.

@preston-evans98
Copy link
Contributor Author

Disabled clippy::uninlined_format_args in borsh/src/generate_schema_schema.rs. Rebased #124 one more time.

@frol frol merged commit 6e360a9 into near:master Feb 8, 2023
This was referenced May 31, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants