Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore(ci): add tests job for MSRV (1.65.0) #151

Merged
merged 2 commits into from
Jun 19, 2023
Merged

chore(ci): add tests job for MSRV (1.65.0) #151

merged 2 commits into from
Jun 19, 2023

Conversation

dj8yfo
Copy link
Collaborator

@dj8yfo dj8yfo commented Jun 19, 2023 •
edited

Resolves #106

@dj8yfo dj8yfo requested a review from frol as a code owner June 19, 2023 12:08
@frol
Copy link
Collaborator

frol commented Jun 19, 2023 •
edited

It seems that version.workspace = true is only supported since Rust 1.64 (released in Sep 2022), and given that even Debian stable already has Rust 1.63, I think it is fine to bump MSRV to 1.64 on our path to stabilization.

@dj8yfo dj8yfo changed the title chore(ci): add tests job for MSRV (1.55.0) chore(ci): add tests job for MSRV (1.65.0) Jun 19, 2023
frol
frol requested changes Jun 19, 2023
View reviewed changes
Copy link
Collaborator

@frol frol left a comment •
edited

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@dj8yfo dj8yfo force-pushed the msrv_in_ci branch 8 times, most recently from ad3a89f to 439b43b Compare June 19, 2023 17:13
@dj8yfo
Copy link
Collaborator Author

dj8yfo commented Jun 19, 2023

1.64 was problematic to include into supported range,
it required specifying time = "=0.3.20" in borsh's Cargo.toml .

frol
frol approved these changes Jun 19, 2023
View reviewed changes
README.md Outdated Show resolved Hide resolved
@frol frol merged commit b7ff8f5 into near:master Jun 19, 2023
4 checks passed
@dj8yfo dj8yfo mentioned this pull request Aug 2, 2023
Merged
@frol frol mentioned this pull request Aug 9, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@frol frol frol approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add MSRV check to CI
2 participants
@dj8yfo @frol