fix: unused fields warn, fields for inner structs of derived BorshSch… #172
Conversation
| @@ -96,6 +96,7 @@ pub fn process_enum(input: &ItemEnum, cratename: Ident) -> syn::Result<TokenStre | |||
| } | |||
| } | |||
| anonymous_defs.extend(quote! { | |||
| #[allow(dead_code)] | |||
There was a problem hiding this comment.
@dj8yfo I don't have all the necessary context here, so I would ask you to look into it: do we even need those unused fields in the struct? I somehow feel uneasy about silencing the compiler here as it might indicate that something is missing / not implemented when it should be.
There was a problem hiding this comment.
I've looked into it.
The fields with their types and possibly #[borsh_skip] attributes are needed to derive correct inner impl BorshSchema for inner structs inside of method of BorshSchema impl for enum. So that type info is still needed.
The compiler is complaining that these structs never get constructed and their fields read.
Which is kind of normal, provided that the structs are invisible outside of the method's scope.
They're accessed by their types instead : <InnerStruct>::declaration(), <InnerStruct as borsh::BorshSchema>::add_definitions_recursively(definitions).
dj8yfo
force-pushed
the
cloned_enum_variant_unused
branch
from
77f3cd3
to
f177635
Compare
…ema method
Resolves #111
An example of repro