Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: #[borsh_skip] on field of struct enum variant (BorshSerialize) #174

Merged
merged 5 commits into from
Jul 5, 2023
Merged

fix: #[borsh_skip] on field of struct enum variant (BorshSerialize) #174

merged 5 commits into from
Jul 5, 2023

Conversation

dj8yfo
Copy link
Collaborator

@dj8yfo dj8yfo commented Jul 3, 2023 •
edited
Loading

Resolves #173

@dj8yfo dj8yfo force-pushed the borsh_skip_enum_struct_variant branch 2 times, most recently from 0198e96 to 80df5df Compare July 3, 2023 18:54
@frol
Copy link
Collaborator

frol commented Jul 4, 2023

@dj8yfo Let's use insta crate for snapshot testing, see this issue on near-sdk-rs and my comment mentioned there: near/near-sdk-rs#1038

@dj8yfo dj8yfo force-pushed the borsh_skip_enum_struct_variant branch 5 times, most recently from 7406aab to fbe04fc Compare July 4, 2023 12:38
@dj8yfo dj8yfo force-pushed the borsh_skip_enum_struct_variant branch from 723166c to abae690 Compare July 4, 2023 13:58
@dj8yfo
Copy link
Collaborator Author

dj8yfo commented Jul 4, 2023 •
edited
Loading

the actual fix is in 2nd commit

@dj8yfo dj8yfo force-pushed the borsh_skip_enum_struct_variant branch from 3211b60 to fcbb9ff Compare July 4, 2023 14:11
@dj8yfo dj8yfo marked this pull request as ready for review July 4, 2023 14:18
@dj8yfo dj8yfo requested a review from frol as a code owner July 4, 2023 14:18
@dj8yfo dj8yfo force-pushed the borsh_skip_enum_struct_variant branch from fcbb9ff to f0b8bf6 Compare July 4, 2023 17:28
frol
frol requested changes Jul 5, 2023
View reviewed changes
borsh-derive-internal/src/enum_ser.rs Outdated Show resolved Hide resolved
borsh-derive-internal/src/enum_ser.rs Outdated Show resolved Hide resolved
borsh-derive-internal/src/enum_ser.rs Outdated Show resolved Hide resolved
@dj8yfo
Copy link
Collaborator Author

dj8yfo commented Jul 5, 2023

i've included change Span::call_site -> Span::mixed_site on three lines in commit

frol
frol approved these changes Jul 5, 2023
View reviewed changes
Copy link
Collaborator

@frol frol left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All the blockers were resolved 🚀

borsh-derive-internal/src/enum_ser.rs Outdated Show resolved Hide resolved
@dj8yfo dj8yfo force-pushed the borsh_skip_enum_struct_variant branch from 8438dd4 to 6080dd9 Compare July 5, 2023 13:31
@dj8yfo dj8yfo merged commit ee5aab0 into near:master Jul 5, 2023
5 checks passed
@dj8yfo dj8yfo mentioned this pull request Aug 2, 2023
Merged
@frol frol mentioned this pull request Aug 9, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@frol frol frol approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

BorshSerialize failure to compile derive with #[borsh_skip] on struct variant field
2 participants
@dj8yfo @frol