Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: filter out foreign attributes in BorshSchema derive for enum #177

Merged
merged 2 commits into from
Jul 5, 2023
Merged

fix: filter out foreign attributes in BorshSchema derive for enum #177

merged 2 commits into from
Jul 5, 2023

Conversation

dj8yfo
Copy link
Collaborator

@dj8yfo dj8yfo commented Jul 4, 2023

Fixes #110

@dj8yfo dj8yfo force-pushed the borsh_schema_clean_foreign_attr_enum branch from 0627ad1 to 132f63b Compare July 5, 2023 14:20
@dj8yfo dj8yfo marked this pull request as ready for review July 5, 2023 14:26
@dj8yfo dj8yfo requested a review from frol as a code owner July 5, 2023 14:26
frol
frol approved these changes Jul 5, 2023
View reviewed changes
Copy link
Collaborator

@frol frol left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Overall, looks good to me, but I caught some small code-style items. Feel free to ignore the "nit" ones.

borsh-schema-derive-internal/src/enum_schema.rs Outdated Show resolved Hide resolved
borsh-schema-derive-internal/src/enum_schema.rs Outdated Show resolved Hide resolved
borsh-schema-derive-internal/src/helpers.rs Outdated Show resolved Hide resolved
@dj8yfo dj8yfo marked this pull request as draft July 5, 2023 17:09
@dj8yfo dj8yfo marked this pull request as ready for review July 5, 2023 17:40
@dj8yfo dj8yfo merged commit 387c665 into near:master Jul 5, 2023
5 checks passed
@dj8yfo dj8yfo mentioned this pull request Aug 2, 2023
Merged
@frol frol mentioned this pull request Aug 9, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@frol frol frol approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Schema does not clean unused attrs from cloned enum struct variants
2 participants
@dj8yfo @frol