refactor!: borsh_init to borsh(init). #187
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
iho
changed the title
dj8yfo
changed the title
frol
approved these changes
Aug 9, 2023
dj8yfo
requested changes
Aug 9, 2023
…", "use_discriminant = ...");
frol
reviewed
Aug 9, 2023
Comment on lines
8
to
10
| let attr = derive_input.attrs.iter().find(|attr| attr.path() == SKIP); | ||
|
|
||
| if attr.is_some() { |
There was a problem hiding this comment.
Just a suggestion, you can use any instead of find + is_some:
Suggested change
| let attr = derive_input.attrs.iter().find(|attr| attr.path() == SKIP); | |
| if attr.is_some() { | |
| if derive_input.attrs.iter().any(|attr| attr.path() == SKIP) { |
This might, however make the code split across several lines and actually make it harder to read
dj8yfo
requested changes
Aug 10, 2023
borsh-derive/src/internals/deserialize/enums/snapshots/borsh_init_func_reversed.snap
Outdated
Show resolved
Hide resolved
dj8yfo
requested changes
Aug 10, 2023
dj8yfo
approved these changes
Aug 10, 2023
This was referenced Aug 10, 2023
Merged
Closed
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #186 and is part of #51
Migration guide: replace all
#[borsh_init(init_method_name)]to#[borsh(init=init_method_name)]