Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Mark is_u8 unsafe #21

Merged
merged 1 commit into from
Mar 18, 2021
Merged

Mark is_u8 unsafe #21

merged 1 commit into from
Mar 18, 2021

Conversation

evgenykuzyakov
Copy link
Contributor

Fixes: #17
Fixes: #18

Marks is_u8 unsafe. Ideally we should not let anyone reimplement it at all, but I'm not sure how to do this with Rust.

Q: Should we release it as a patch or minor version?

Copy link
Member

@ailisp ailisp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good

Copy link
Collaborator

@frol frol left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We should release it as a minor release to avoid sudden compilation errors down the line

@frol frol merged commit 2029957 into master Mar 18, 2021
@frol frol mentioned this pull request May 31, 2023
@frol frol deleted the mark_is_u8_unsafe branch June 2, 2023 20:04
@frol frol mentioned this pull request Jun 6, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
3 participants