Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add derive_use_cargo default feature #272

Closed
wants to merge 2 commits into from

Conversation

dj8yfo
Copy link
Collaborator

@dj8yfo dj8yfo commented Dec 11, 2023

resolves #271

a way to disable proc-macro-crate (it depends on cargo binary being available) without annotating each derive with tautological #[borsh(crate = "borsh")]

sample1, derive_use_cargo : default features
sample1 : proc-macro-crate dependency in Cargo.lock

sample2, derive_no_use_cargo : opt-out of derive_use_cargo feature
sample2 : proc-macro-crate dependency absent in Cargo.lock


NOTE: this change causes breakage for no_std projects with borsh dependency renamed - sample3, derive_no_std_rename_breakage
This commit breaks
compilation on version update, and this fixes it.

@dj8yfo dj8yfo marked this pull request as ready for review December 13, 2023 15:11
@dj8yfo dj8yfo requested a review from frol as a code owner December 13, 2023 15:11
@frol
Copy link
Collaborator

frol commented Dec 13, 2023

I am closing this PR as per #271 (comment)

@frol frol closed this Dec 13, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

derive macros require cargo to be present
2 participants