Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

upgrade hashbrown #53

Merged
merged 2 commits into from
Dec 22, 2021
Merged

upgrade hashbrown #53

merged 2 commits into from
Dec 22, 2021

Conversation

matklad
Copy link
Contributor

@matklad matklad commented Dec 16, 2021

The primary goal is to remove old hashbrown from nearcore.

I considered making a larger change and actually hiding hashbrown altogether, but, on ballance, this seems like the best first step. If we want to break the API, there's quite a few things we might want to do #51

@matklad matklad requested a review from frol as a code owner December 16, 2021 15:43
Copy link
Contributor

@austinabell austinabell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this case is pretty impossible to hit for users where this is a breaking change and anyone building a contract should already have a lockfile. I can't personally think of a reasonable way this would cause any issue to be a patch release

@matklad matklad merged commit 5d370d2 into near:master Dec 22, 2021
This was referenced May 31, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants