feat: Added support for BTreeMap, BTreeSet, BinaryHeap, LinkedList types #6
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
frol
changed the title
ailisp
reviewed
Jan 12, 2021
| #[inline] | ||
| fn deserialize(buf: &mut &[u8]) -> Result<Self> { | ||
| let vec = <Vec<T>>::deserialize(buf)?; | ||
| Ok(vec.into_iter().collect::<LinkedList<T>>()) |
There was a problem hiding this comment.
This code looks beautiful, however do we concern about avoid extra copy and convert cost, if we really want highest performance?
There was a problem hiding this comment.
That is how HashSet was already implemented. I think we can have another round of writing a helper to deserialize into an iterator and thus optimize the performance and avoid duplicate code
ailisp
reviewed
Jan 12, 2021
…ion is consistent (Map is sorted by key and Set is sorted by value)
…for-more-built-in-types
Merged
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #5