feat: add proper support for isize and usize #99
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Makes sense to me: in general, it's not true that borsh types correspond to rust types (eg, collections are restricted to u32::MAX elements only), so this seems exactly like how it should be. |
frol
approved these changes
Aug 3, 2022
|
Also, just noticed that we have |
|
This PR makes perfect sense to me. Thanks for aligning things! |
Merged
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #40 and #49
Technically,
isize/usizehave different deserialization semantics fromi64/u64, but sinceisize/usizeare not a part of the spec I guess we don't really have many options.