-
Notifications
You must be signed in to change notification settings - Fork 15
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Deduplicate warnings #68
Conversation
@itegulov, when you get the time please can you test this. My one test in the screenshot worked, but ever since, I've been unable to get any warnings at all through maybe it's the meds I'm on |
@miraclx yeah I am not getting any warnings either |
Fixed in |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can confirm that warnings appear now!
rustflags.push_str(value); | ||
} | ||
_ => { | ||
final_env.insert(key, value.to_string()); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
curious, why use a map instead of just a vec of (K, V)
if you're not checking the duplication of keys on insert?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Well, actually, for RUSTFLAGS
, we're checking to ensure we don't replace previous entries, but instead concatenate them. So it's here to allow us quickly index the map, instead of having to iterate the whole Vec<(K, V)>
.
6b6b66c
to
2b98c63
Compare
Co-authored-by: Daniyar Itegulov <ditegulov@gmail.com>
d099605
to
9907364
Compare
Fixes #67
Hides warnings at the ABI generation stage only when building contracts