New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
rustup and wasm32-unknown-unknown auto setup #632
Conversation
409480c
to
dcd6d1f
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm besides few nits
disclaimer: I didn't test whether works alright
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can you put an example of what this complete interaction looks like (as a screenshot or copy-pasted text) in the description of this PR, please?
Co-authored-by: Chad Ostrowski <221614+chadoh@users.noreply.github.com>
Co-authored-by: Chad Ostrowski <221614+chadoh@users.noreply.github.com>
Co-authored-by: Chad Ostrowski <221614+chadoh@users.noreply.github.com>
Co-authored-by: Chad Ostrowski <221614+chadoh@users.noreply.github.com>
Co-authored-by: Chad Ostrowski <221614+chadoh@users.noreply.github.com>
Co-authored-by: Chad Ostrowski <221614+chadoh@users.noreply.github.com>
Co-authored-by: Chad Ostrowski <221614+chadoh@users.noreply.github.com>
Co-authored-by: Chad Ostrowski <221614+chadoh@users.noreply.github.com>
Co-authored-by: Chad Ostrowski <221614+chadoh@users.noreply.github.com>
Co-authored-by: Chad Ostrowski <221614+chadoh@users.noreply.github.com>
Co-authored-by: Chad Ostrowski <221614+chadoh@users.noreply.github.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
One more nit, see below, and I also noticed that the rust-setup.js
file has four-space indents instead of 2 like the rest of the project. This project even has a .editorconfig
file that specifies two-space indents. Please configure your editor to honor this file.
But these are small things, and I don't need to review this PR again once you address them. This change looks great and it'll make a big difference for newbie NEARies who want to use Rust! Thank you!
Tested on Linux (Arch + Bash/ZSH)
Latest Mac OS (ZSH)
Windows 10 (Power Shell)
It will be great to run it on your PC. Don't forget to clear
.bashrc
,.zshenv
, etc., and make sure that cargo is not in thePATH
before the test.Example: