Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add internationalization #11

Merged
merged 6 commits into from Jul 17, 2023
Merged

Add internationalization #11

merged 6 commits into from Jul 17, 2023

Conversation

HarisSQA
Copy link
Collaborator

Added i18n translator and created a folder with EN and DE languages files. Also added DEBUG : true for development purpuse

@HarisSQA HarisSQA linked an issue Jul 11, 2023 that may be closed by this pull request
Add internationalization #7
Closed
esaminu
esaminu requested changes Jul 14, 2023
View reviewed changes
Copy link
Collaborator

@esaminu esaminu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we remove package-lock.json since yarn will be used for package management in this project. Otherwise LGTM

@HarisSQA
Copy link
Collaborator Author

Yes, I will do it right now.

@esaminu
Copy link
Collaborator

esaminu commented Jul 14, 2023

Thanks @HarisSQA could you rebase and internationalize the newly added copy?

@HarisSQA
Copy link
Collaborator Author

Hi @esaminu ,
I still saw conflicts in these files. I rebase main into my branch so this shouldn't be. I test it and everything working fine.

esaminu
esaminu approved these changes Jul 17, 2023
View reviewed changes
Copy link
Collaborator

@esaminu esaminu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM ✅

@esaminu esaminu merged commit f9294cc into main Jul 17, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@esaminu esaminu esaminu approved these changes

@MaximusHaximus MaximusHaximus Awaiting requested review from MaximusHaximus

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add internationalization
3 participants
@HarisSQA @esaminu @amirsaran3