Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Debounce API calls to validate email and username #147

Merged
merged 3 commits into from Jan 12, 2024

Conversation

Pessina
Copy link
Contributor

@Pessina Pessina commented Jan 8, 2024

No description provided.

Copy link

vercel bot commented Jan 8, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
fast-auth-signer ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jan 11, 2024 10:40pm

@@ -50,6 +49,7 @@
"https-browserify": "^1.0.0",
"i18next": "^23.2.8",
"js-sha256": "^0.10.1",
"lodash": "^4.17.21",
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

instead of loading whole lib, lets just import debounce only
https://www.npmjs.com/package/lodash.debounce

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good point, let me change it!

Copy link
Collaborator

@hcho112 hcho112 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Pessina Pessina merged commit c695de7 into main Jan 12, 2024
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants