Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Initialize Firestore on App.tsx #176

Open
wants to merge 6 commits into
base: main
Choose a base branch
from

Conversation

Pessina
Copy link
Collaborator

@Pessina Pessina commented Feb 11, 2024

No description provided.

Copy link

vercel bot commented Feb 11, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
fast-auth-signer ✅ Ready (Inspect) Visit Preview 💬 Add feedback Feb 12, 2024 8:59am

@Pessina Pessina requested review from hcho112 and esaminu and removed request for hcho112 February 11, 2024 11:54
@hcho112
Copy link
Collaborator

hcho112 commented Feb 12, 2024

I have pulled this PR locally and conducted a test with following condition:

  1. Use current main branch on fast-auth-signer
  2. Sign in with existing account on Chrome browser
  3. Sign out
  4. Check out to current branch
  5. Attempt to sign in

I see this error message:
image

Maybe we need to look into further?

@hcho112
Copy link
Collaborator

hcho112 commented Feb 12, 2024

above error is occurred from https://github.com/near/fast-auth-signer/blob/main/packages/near-fast-auth-signer/src/lib/controller.ts#L293

Maybe if user fail at this point, we send them email verification here?
(eg, it would make sense to re-verify here because if expected oidc is absent, first thing we should do is email verification)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants