Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

18 implement sign route #37

Merged
merged 49 commits into from Sep 19, 2023
Merged

18 implement sign route #37

merged 49 commits into from Sep 19, 2023

Conversation

amirsaran3
Copy link
Collaborator

No description provided.

HarisSQA and others added 30 commits July 11, 2023 17:49
…-implement-sign-route

# Conflicts:
#	.eslintrc.js
#	package.json
#	src/App.tsx
#	src/components/Layout/Layout.tsx
#	src/components/Sign/Sign.tsx
#	src/styles/index.tsx
#	tsconfig.json
#	yarn.lock
@amirsaran3 amirsaran3 marked this pull request as ready for review September 6, 2023 05:34
Copy link
Collaborator

@esaminu esaminu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM please address comment in a follow up PR

}

const transactionHashes = searchParams.get('transactions');
const deserializedTransactions = deserializeTransactionsFromString(transactionHashes);
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we redirect to failure_url if invalid borsh is passed in? Please address in a follow up PR

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants