Disable auto delete lak, decoupling FAK, LAK on firestore, improvements on Devices page #73
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
esaminu
force-pushed
the
main
branch
2 times, most recently
from
8b0b228
to
242a52f
Compare
esaminu
reviewed
Oct 4, 2023
| @@ -180,6 +180,7 @@ function SignInPage() { | |||
| const public_key = decodeIfTruthy(searchParams.get('public_key')); | |||
| const contract_id = decodeIfTruthy(searchParams.get('contract_id')); | |||
| const methodNames = decodeIfTruthy(searchParams.get('methodNames')); | |||
| const gateway = decodeIfTruthy(searchParams.get('gateway')); | |||
There was a problem hiding this comment.
gateway should be inferred from success_url. IMO we can use the domain name here
There was a problem hiding this comment.
Actually good idea!, will make update shortly
esaminu
force-pushed
the
main
branch
2 times, most recently
from
4ff83ef
to
3de0272
Compare
hcho112
force-pushed
the
disable-auto-delete-lak
branch
from
5591d27
to
2fdb190
Compare
|
Rebased and updated with change request |
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR contains following changes: