Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: dynamically import module with native node dependencies #1111

Merged
merged 2 commits into from Apr 18, 2023

Conversation

andy-haynes
Copy link
Collaborator

@andy-haynes andy-haynes commented Apr 18, 2023

Pre-flight checklist

  • I have read the Contributing Guidelines on pull requests.
  • Commit messages follow the conventional commits spec
  • If this is a code change: I have written unit tests.
  • If this changes code in a published package: I have run pnpm changeset to create a changeset JSON document appropriate for this change.
  • If this is a new API or substantial change: the PR has an accompanying issue (closes #0000) and the maintainers have approved on my working plan.

Motivation

Fixes #1109

Test Plan

NodeJS tests passing ensures that no changes will affect that environment. Browser bundles will similarly continue to function the same way as this change does not change evaluation order of global.fetch. React Native environments will now be able to import @near-js/providers.

Related issues/PRs

Fixes #1109

@changeset-bot
Copy link

changeset-bot bot commented Apr 18, 2023

🦋 Changeset detected

Latest commit: d6d53ab

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 5 packages
Name Type
@near-js/providers Patch
@near-js/accounts Patch
@near-js/cookbook Patch
near-api-js Patch
@near-js/wallet-account Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@andy-haynes andy-haynes merged commit 475afa9 into master Apr 18, 2023
1 check passed
@andy-haynes andy-haynes deleted the fix/fetch branch April 18, 2023 20:12
@github-actions github-actions bot mentioned this pull request Apr 18, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

http could not be found within the project
2 participants