Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: add missing fields to execution outcome and test #1113

Merged
merged 6 commits into from Apr 27, 2023

Conversation

austinabell
Copy link
Contributor

Pre-flight checklist

  • I have read the Contributing Guidelines on pull requests.
  • Commit messages follow the conventional commits spec
  • If this is a code change: I have written unit tests.
  • If this changes code in a published package: I have run pnpm changeset to create a changeset JSON document appropriate for this change.
  • If this is a new API or substantial change: the PR has an accompanying issue (closes #0000) and the maintainers have approved on my working plan.

Motivation

This RPC type is missing fields that are required for proof verification. There is another metadata field and compute_usage fields that are missing also, but I opted to keeping these changes light.

I defaulted to having this be a patch changeset, but can change to minor if intended. Unclear how semver is with TS adding fields to interfaces (esp in this case since those types shouldn't be constructed manually)

Test Plan

updated an existing test

Related issues/PRs

@changeset-bot
Copy link

changeset-bot bot commented Apr 23, 2023

🦋 Changeset detected

Latest commit: 188107a

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 14 packages
Name Type
@near-js/types Patch
@near-js/accounts Patch
@near-js/crypto Patch
@near-js/keystores Patch
near-api-js Patch
@near-js/providers Patch
@near-js/transactions Patch
@near-js/utils Patch
@near-js/wallet-account Patch
@near-js/cookbook Patch
@near-js/biometric-ed25519 Patch
@near-js/keystores-browser Patch
@near-js/keystores-node Patch
@near-js/signers Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

packages/near-api-js/test/providers.test.js Outdated Show resolved Hide resolved
.changeset/rotten-monkeys-tie.md Outdated Show resolved Hide resolved
@andy-haynes andy-haynes merged commit 842c1bc into near:master Apr 27, 2023
1 check passed
@andy-haynes
Copy link
Collaborator

Thanks @austinabell !

@github-actions github-actions bot mentioned this pull request Apr 27, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants