Address code review comments

near · Apr 22, 2020 · 1f79bbd · 1f79bbd
1 parent e6684af
commit 1f79bbd
Show file tree

Hide file tree

Showing 4 changed files with 9 additions and 8 deletions.
diff --git a/commands/create-account.js b/commands/create-account.js
@@ -33,7 +33,6 @@ module.exports = {
 
 async function createAccount(options) {
     await eventtracking.track(eventtracking.EVENT_ID_CREATE_ACCOUNT_START, {});
-    console.log("?")
     options.initialBalance = utils.format.parseNearAmount(options.initialBalance);
     // NOTE: initialBalance is passed as part of config here
     let near = await connect(options);

diff --git a/test/index.sh b/test/index.sh
@@ -1,7 +1,7 @@
 #!/bin/bash
 OVERALL_RESULT=0
 mkdir ~/.near-config
-cp ./test/testsettings ~/.near-config/settings
+cp ./test/testsettings ~/.near-config/settings.json
 for test in ./test/test_*; do
     echo ""
     echo "Running $test"

diff --git a/utils/eventtracking.js b/utils/eventtracking.js
@@ -6,7 +6,7 @@ const chalk = require('chalk');  // colorize output
 const readline = require('readline');
 const settings = require('./settings');
 
-const TRACKING_ENABLED_KEY = 'trackingEnaled';
+const TRACKING_ENABLED_KEY = 'trackingEnabled';
 const TRACKING_SESSION_ID_KEY = 'trackingSessionId';
 
 const track = async (eventType, eventProperties) => {
@@ -52,7 +52,7 @@ const track = async (eventType, eventProperties) => {
 
     try {
         const mixPanelProperties = {
-            distinct_id: shellSettings.trackingSessionId
+            distinct_id: shellSettings[TRACKING_SESSION_ID_KEY]
         };
         Object.assign(mixPanelProperties, eventProperties);
         mixpanel.track(eventType, mixPanelProperties);

diff --git a/utils/settings.js b/utils/settings.js
@@ -4,14 +4,16 @@ const path = require('path');
 
 
 // Persistent shell settings
+const SETTINGS_FILE_NAME = 'settings.json';
+const SETTINGS_DIR = '.near-config';
 
 const getShellSettings = () => {
-    const nearPath = path.join(homedir, '.near-config');
+    const nearPath = path.join(homedir, SETTINGS_DIR);
     try {
         if (!fs.existsSync(nearPath)) {
             fs.mkdirSync(nearPath);
         }
-        const shellSettingsPath = path.join(nearPath, 'settings');
+        const shellSettingsPath = path.join(nearPath, SETTINGS_FILE_NAME);
         if (!fs.existsSync(shellSettingsPath)) {
             return {};
         } else {
@@ -24,12 +26,12 @@ const getShellSettings = () => {
 };
 
 const saveShellSettings = (settings) => {
-    const nearPath = path.join(homedir, '.near-config');
+    const nearPath = path.join(homedir, SETTINGS_DIR);
     try {
         if (!fs.existsSync(nearPath)) {
             fs.mkdirSync(nearPath);
         }
-        const shellSettingsPath = path.join(nearPath, 'settings');
+        const shellSettingsPath = path.join(nearPath, SETTINGS_FILE_NAME);
         fs.writeFileSync(shellSettingsPath, JSON.stringify(settings));
     } catch (e) {
         console.log(e);