fix: move x-api-key logic to middlewares #1052
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
xilosada
changed the title
xilosada
changed the title
xilosada
changed the title
xilosada
force-pushed
the
use_middleware_to_set_apkikey
branch
from
f422a97
to
dd7f04f
Compare
|
No objections here, but I want to see green CI. We need to setup tests for external contributors (I do not have the rights). I will ping somebody to change it. |
|
@volovyks any update on this one :) |
|
Hi @xilosada we just enabled ci for PR from fork. Please merge current master to your branch and that will trigger CI! |
xilosada
force-pushed
the
use_middleware_to_set_apkikey
branch
from
dd7f04f
to
394cc9c
Compare
|
Nice fix! Thank you @xilosada! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #1051
The current implementation of the Near CLI that sets the x-api-key value in the yargs config. This approach ignores the
nodeUrloption passed to the commands. It makes it difficult to manage custom RPCs since the x-api-key is bound to the nodeUrl in the config.The proposed solution sets the x-api-key value in a middleware instead of the config file. This middleware applies the actual nodeUrl value passed to the command.