Fix tx-status to handle account id better #189
Conversation
|
It is really a goo idea to separate the command when you fix it. |
| } | ||
| accountId = accountId || argv.accountId || argv.masterAccount; | ||
|
|
||
| if (!accountId) { |
There was a problem hiding this comment.
in this command, accountId is actually not required and user will only follow the command we give not given the account id by default? Maybe change instructions in the readme for this since if not accountId, there will throw an error.
There was a problem hiding this comment.
the intent is to change other tools to return transaction hash as accountId:hash, so we can just have one string that can be copy-pasted
see #187
Seemed like good opportunity to do this. If command was more complex I'd split the change in 2 separate (first move, then fix).
I didn't add any new command, not sure what do you mean. |
|
near generate-key and near repl is not added. Also, still not clear about accountid problem I left above? |
these aren't part of this PR |
|
Fixes #187