[near-cli] fix deploy to work with latest devnet (param was removed) #2
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vgrichina
approved these changes
Mar 1, 2019
gulpfile.js
Outdated
| @@ -63,7 +63,8 @@ gulp.task('createDevAccount', async function(argv) { | |||
|
|
|||
|
|
|||
| async function deployContractAndWaitForTransaction(accountId, contractName, data, near) { | |||
| const deployContractResult = await near.deployContract(accountId, contractName, data); | |||
| console.log(data[data.length-1]); | |||
There was a problem hiding this comment.
is this console.log still needed?
gulpfile.js
Outdated
| @@ -92,7 +93,8 @@ gulp.task('deploy', async function(argv) { | |||
| }; | |||
|
|
|||
| const near = await neardev.connect(options); | |||
| const contractData = [...fs.readFileSync('./out/main.wasm')]; | |||
| console.log("deploying file ../tests/hello.wasm"); | |||
There was a problem hiding this comment.
should use actual file name
janedegtiareva
added a commit
that referenced
this pull request
Aug 2, 2019
janedegtiareva
added a commit
that referenced
this pull request
Apr 30, 2020
janedegtiareva
added a commit
that referenced
this pull request
Apr 30, 2020
* Move default location for credentials to .near-credentials Also fix an issue that login is not honoring the system-wide keystore and creating its own version. * Updated todos according to the present state of key management * Change where the dev-account is stored to not be coupled to keystore * Fix lint errors * Fix more lint errors * fix more lint errors * Update test to use the new key location * Fix test try #2 * Add more logs to test_generate_key to help troublshoot test failures * Update path to keyfile to fix test take 2
crypto-guys
added a commit
to crypto-guys/near-cli
that referenced
this pull request
Feb 16, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.