-
Notifications
You must be signed in to change notification settings - Fork 92
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
small tweaks to settings.js which is used from main.html #22
Conversation
to make local ui development experience better
I think it makes sense to align this with changes I've been making to make GH pages work well for: I think we need to agree on how to solve #21, cause otherwise it's very inconvenient to switch between local / shared devnet. |
re GH pages - settings.js looks pretty much identical except for setting the fiddle cookie. Can we actually change that? I don't want the real app code to say "fiddle" anywhere. Why can't we just read the values from the settings.js directly and bypass fiddle config? #21 - switching between envs is just passing node url at this point. I do not think that improving this is higher priority than key management, so will not work on it right now. |
I agree we shouldn't use cookie, that's just hack to make stuff work quickly. I'm thinking that it makes sense to change it as part of doing #21, so that e.g. we have few .json config files (one per environment). |
Cool! This MR is going in that direction by adding 2 settings files. You still need to specify which one to use manually, but this is something that can be iterated on. |
blank_project/src/index.html
Outdated
@@ -7,11 +7,11 @@ | |||
</head> | |||
<body style="background: #fff"> | |||
<div class="container"> | |||
Contract says: | |||
Contract says 2: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@janedegtiareva hmm, seems like typo
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
good catch. I use these sometimes to make sure i am looking at the latest stuff and forget to undo lol
to make local ui development experience better