-
Notifications
You must be signed in to change notification settings - Fork 92
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support GH pages, build with gulp #24
Conversation
Is there are a better option than a hard copy for assembly-json and near-runtime-ts files? |
@evgenykuzyakov waiting for AssemblyScript/assemblyscript#448 to land. Probably can also hack it myself on a level of overriding |
I'm fine with copying from blank_project. I just don't want us to have a copy in this repo. |
"deploy": "npm run build && npm run deploy:contract && npm run deploy:pages", | ||
"prestart": "npm run build && npm run deploy:contract", | ||
"start": "python3 -mhttp.server --directory src", | ||
"test": "npm run build && jest test --env=near-shell/local_test_environment", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
nit: I liked the test environment better under src, to not pollute the top level dir
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@janedegtiareva it's used from near-shell
node module (i.e. it's not present in project template at all anymore).
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It's a good file to have in the project template to allow devs to modify the default behaviour.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ah, I see, there is some app-specific stuff
It looks like files are largely identical though, except nodeUrl
. So I think probably best would be to load this stuff from env-specific config and then have common test env use project-specific config.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Some sort of base makes sense
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Leaving as is for this PR, gonna clean-up as part of #21
The near build command handled this without hardcoding. Can we at least use that solution? |
It's not compatible with NEARStudio. Not sure what do you mean by "near build command handled this without hardcoding". Wasn't it merely copying files from hard-coded locations?
It's pretty trivial to add this hardcoded mapping on |
ebb0f74
to
7defb86
Compare
GitLab failure gonna be resolved after merge (cause build depends on stuff not merged yet). |
Main selling point is that
npm run deploy
build and deploys everything.