[nearshell] build works on standard files #3
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vgrichina
approved these changes
Mar 5, 2019
There was a problem hiding this comment.
This should work fine. However right now typical build process would be like:
Compile:
npm -> near -> gulp -> asc (compile)
Deploy:
npm -> near (deploy)
I think it instead should be:
Compile:
npm -> gulp -> near as a lib -> asc
Deploy:
npm -> gulp -> near (deploy)
I think this will make our CLI tools even better cause:
gulpis a versatile tool which can be used for a lot of other app build tasks, web dev folks know it- people should be able to replace
gulpeasily as not everyone wants to use it. This is much easier whenneardoesn't callgulp.
| @@ -75,6 +86,17 @@ async function deployContractAndWaitForTransaction(accountId, contractName, data | |||
| return waitResult; | |||
| } | |||
|
|
|||
| // converts file.ts to file.near.ts | |||
| function generateNearFileName(fileName) { | |||
There was a problem hiding this comment.
fileName.replace(/.ts$/, '.near.ts')
There was a problem hiding this comment.
or if you want to be pedantic about path handling, it's in node's std: https://nodejs.org/api/path.html#path_path_basename_path_ext
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.