Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Revert "generate function for asking id" #594

Merged
merged 1 commit into from Nov 7, 2020
Merged

Revert "generate function for asking id" #594

merged 1 commit into from Nov 7, 2020

Conversation

vgrichina
Copy link
Contributor

Reverts #581

@vgrichina
Copy link
Contributor Author

Reverting as this breaks usage in batch scripts (as evident by the fact that tests needed to be updated).

There is existing askForConsentIfNeeded method where we should add text about account ID sharing consent. It is called only from commands which are known to be user-interactive and so doesn't interfere with batch usage or any other cases where user doesn't expect question (e.g. near keys account.near | grep app.account.near)

@vgrichina vgrichina merged commit 52222b2 into master Nov 7, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mikedotexe mikedotexe Awaiting requested review from mikedotexe

@icerove icerove Awaiting requested review from icerove

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
1 participant
@vgrichina