updated signAndSendTranscation to use object args #784
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
volovyks
reviewed
Jun 3, 2021
|
We had one more deprecation warning: |
Added space between the key & value Co-authored-by: Serhii Volovyk <SergeyVolovyk@gmail.com>
PR #782 fixed this @volovyk-s 🙂 |
thisisjoshford
approved these changes
Jun 3, 2021
thisisjoshford
approved these changes
Jun 3, 2021
There was a problem hiding this comment.
Awesome! Thanks for the contribution @Rishabhraghwendra18 🙏🏼
volovyks
approved these changes
Jun 3, 2021
No problem . I want to contribute more to this organization. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue No - #760
Desc: We were using
signAndSendTranscationas positional args which is deprecated innear-api-js. This PR updates this command to use the newer function call method of passing arguments as an object.