Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Number of seats changed to 1 in PV 49+ #898

Merged
merged 1 commit into from
Dec 9, 2021
Merged

Number of seats changed to 1 in PV 49+ #898

merged 1 commit into from
Dec 9, 2021

Conversation

volovyks
Copy link
Collaborator

@volovyks volovyks commented Dec 9, 2021 •
edited

It supports both old and new Protocol Versions. I decided not to delete the column, because it's a breaking change.

@volovyks volovyks requested review from frol and nikurt December 9, 2021 16:08
@volovyks volovyks self-assigned this Dec 9, 2021
nikurt
nikurt approved these changes Dec 9, 2021
View reviewed changes
Copy link
Contributor

@nikurt nikurt left a comment •
edited

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tried the change locally, looks good.

I suggest to drop the "#Seats" column after the 1.23.0 release, as it no longer provides any additional value.

@volovyks
Copy link
Collaborator Author

volovyks commented Dec 9, 2021

@nikurt I will drop it on the next breaking change and major version upgrade.

@volovyks volovyks merged commit b9d499f into master Dec 9, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nikurt nikurt nikurt approved these changes

@frol frol Awaiting requested review from frol

Assignees

@volovyks volovyks

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@volovyks @nikurt